using Requires for Statistics#255
Merged
johnnychen94 merged 1 commit intoJuliaMath:masterfrom Jul 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 6 6
Lines 763 763
=======================================
Hits 710 710
Misses 53 53 Continue to review full report at Codecov.
|
Because Statistics is no longer part of the Julia sysimage, the package loading time of FixedPointNumbers is then donimated by Statistics. This commit uses Requires to conditionally add the needed method without making more one-line package. This, of course, adds some additional overhead but I do believe it's currently the best tradeoff until we have first-class support on conditional package loading.
timholy
approved these changes
Jul 8, 2022
Collaborator
Author
|
I'm merging this, but we won't be able to make a new release because many breaking changes have been introduced since the last release. We need to sort out and finish what's planned for 0.9.0. This is why I've tagged a dev version #258 to avoid a breaking patch release by accident. |
kimikage
added a commit
that referenced
this pull request
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Statistics is no longer part of the Julia sysimage, the package loading
time of FixedPointNumbers is then donimated by Statistics. This commit uses
Requires to conditionally add the needed method without making more one-line
package. This, of course, adds some additional overhead but I do believe it's
currently the best tradeoff until we have first-class support on conditional
package loading.