Skip to content

AbstractShape parameter unnecessary for AbstractObject? #45

@StackEnjoyer

Description

@StackEnjoyer

Currently, a major building block of the API is defined as

abstract type AbstractObject{T <: Real, S <: AbstractShape{T}} end

This is a legacy of the early days. In the mean time, SingleShape and MultiShape types have been introduced, making the AbstractShape parameter meaningless. I recommend we get rid of it. There are currently no functions in BMO that use this parameter for dispatch anyways. This will be a breaking change ofc for all users that implement some form of <: AbstractObject.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions