Use world-age aware access to #Unitful_basefactors#819
Merged
giordano merged 2 commits intoJuliaPhysics:masterfrom Oct 19, 2025
Merged
Use world-age aware access to #Unitful_basefactors#819giordano merged 2 commits intoJuliaPhysics:masterfrom
giordano merged 2 commits intoJuliaPhysics:masterfrom
Conversation
When defining a new unit with `@unit` in a different module, there is a world age warning with master on 1.12. This PR fixes it. Fixes: JuliaPhysics#781
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
=========================================
Coverage ? 89.52%
=========================================
Files ? 21
Lines ? 1699
Branches ? 0
=========================================
Hits ? 1521
Misses ? 178
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giordano
reviewed
Oct 19, 2025
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When defining a new unit with
@unitin a different module, there is a world age warning with master on 1.12. This PR fixes it.Fixes: #781