Report max_worker_rss in verbose mode - #149
Merged
Merged
Conversation
Collaborator
Author
|
Failures seem unrelated I can also reproduce locally on main with latest nightly |
giordano
approved these changes
Jul 28, 2026
giordano
left a comment
giordano
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, but it'd be nice to figure out the failure on nightly too (does it cause test failures for downstream packages?). I don't really have time to look into it this week.
Collaborator
Author
Collaborator
Author
|
Just force-pushed a simplification that won't show up in github's history but I just removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.