Print max RSS in red if a worker is to be killed - #151
Conversation
|
I'll merge this before registering the bugfix |
|
Should have a test for this? It should be easy to test, but perhaps it's a too niche and specific of a feature to test it. Also, a mention in the docs to explain what's the red for? That could be obscure to other users. |
|
Yeah I should definitely add a mention in the docs. As for a test, we don't seem to test any other output styling so I didn't bother. I'll also be directly testing CUDA.jl with this before merging |
| - GC time and percentage | ||
| - Memory allocation | ||
| - RSS (Resident Set Size) memory usage | ||
| - RSS (Resident Set Size) memory usage, shown in red once it exceeds the RSS threshold and the worker will be restarted |
There was a problem hiding this comment.
This was suggested by Claude. I thing it's the right place to bring it up, but I'm not sure I like how it's the only option to have extra details.
There was a problem hiding this comment.
I don't think this is a blocker we can always tweak the wording if needed
|
CUDA seems fine |
|
I'm liking the visual clue, but perhaps a slightly less alarming colour (like yellow?) would be better? |
|
I have no issues with using yellow |
2 participants
I've been finding myself wanting a more obvious way to tell if a worker was killed or not. Having RSS show up red seems like a good way to indicate that the threshold was reached and therefore the worker will be stopped.
Passing the info as IO context makes this non-breaking for custom TestRecords
Example:
