using is_fixed - #28
Conversation
|
Hopefully you can test it by adding what ever package triggered the problem as a test time dependency, |
|
Alas, the version of ChainRulesCore required in the test deps and KernelFunctions aren't yet compatible. Any other suggestions? |
|
Change the version of ChainRulesCore to one that is compatible. |
|
Okay -- I've not restricted CRC to 0.10.13, which is compatible with KernelFunctions 0.10.12. Is this alright? I'm still not really clear on how to know if this is a permissible version of CRC. |
Codecov Report
@@ Coverage Diff @@
## release-1.4 #28 +/- ##
===============================================
+ Coverage 78.75% 79.48% +0.73%
===============================================
Files 4 3 -1
Lines 80 78 -2
===============================================
- Hits 63 62 -1
+ Misses 17 16 -1
Continue to review full report at Codecov.
|
|
Change of plan -- I've added a laughably simple test to prevent reversion, because I was unable to find a version of KernelFunctions which played nicely with ChainRulesCore on 1.4, 1.5, and 1.6, nor was I able to really tie down the cause of hitting that particular branch. |
| push!(LOAD_PATH, mktempdir()) # put something weird in LOAD_PATH for testing | ||
| orig_load_path = Base.LOAD_PATH | ||
| try | ||
| TestEnv.activate("KernelFunctions") |
There was a problem hiding this comment.
| TestEnv.activate("KernelFunctions") | |
| TestEnv.activate("KernelFunctions") | |
| @test true # would have errored before this point if this failed. |
| end | ||
| end | ||
|
|
||
| # See #26 |
There was a problem hiding this comment.
I prefer full URLs for comments so I can click them to go the other code
| # See #26 | |
| # See https://github.com/JuliaTesting/TestEnv.jl/issues/26 |
| end | ||
|
|
||
| # See #26 | ||
| @testset "KernelFunctions" begin |
There was a problem hiding this comment.
| @testset "KernelFunctions" begin | |
| @testset "KernelFunctions: is_fixed issue" begin |
It just needs to have the same test-time dependencies. |
| end | ||
|
|
||
| # https://github.com/JuliaTesting/TestEnv.jl/issues/26 | ||
| @test isdefined(TestEnv, :isfixed) |
There was a problem hiding this comment.
Welp, I guess that works.
Feels unsatisfying, since it is testing implementation rather than problem, though.
There was a problem hiding this comment.
Completely agree. Presumably the fact that it isn't hit in the existing tests means that a chunk of code doesn't get tested :(
|
lets merge this and later worry about finding a better test |
3 participants
As per @oxinabox 's request in #26 .
I'm not sure how to test this as I'm not entirely sure what the problem was in the first place 🤷