Release 0.12.0 - #104
Merged
Merged
Conversation
added 2 commits
April 29, 2020 11:42
ctdio
approved these changes
Apr 29, 2020
ctdio
reviewed
Apr 29, 2020
| ### Added | ||
|
|
||
| - Updated `@jupiterone/data-model@0.3.1` | ||
|
|
Contributor
There was a problem hiding this comment.
This should probably be moved above 0.11.4, but nbd
Contributor
Author
There was a problem hiding this comment.
Yup, noted in opening comment, since I noticed after pushing up tags etc. Thanks for the approve!
Contributor
There was a problem hiding this comment.
Ooof idk how I missed the opening comment. Sorry about that
jmountifield
added a commit
that referenced
this pull request
Apr 29, 2026
Tracks data-model PR #104 review: NHI properties (nhiType, isAi, aiConfidence, aiPlatform, nhiOwnerStatus) no longer use the underscore prefix, since underscore is conventionally reserved for system-managed fields (_class, _type, _key, _rawData) and domain metadata follows bare-name conventions elsewhere (User.username, AccessKey.fingerprint). Updates DEFAULT_PERMISSIVE_ENUM_PROPERTIES, JSDoc @example, and all test fixtures + assertions to use the renamed property names. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jmountifield
added a commit
that referenced
this pull request
Apr 29, 2026
…Entity owner Tracks data-model PR #104 review: - Inline NHI schemas in all three test files now use bare property names (nhiType, isAi, aiConfidence, aiPlatform, nhiOwnerStatus) matching the data-model NHI.json convention. Underscore prefix is reserved for system-managed fields (_class, _type, _key). - Drop the _nhiOwner property entirely. The data-model schema redeclares Entity's existing `owner` field with an NHI-specific description rather than introducing a separate property — the inline test fixtures now match that shape. - Update test data and assertions accordingly. NHI_PROPERTIES whitelist array drops _nhiOwner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed the CHANGELOG is a bit out of order, will fix in another PR, not worth deleting tags and whatnot to clean up.