Skip to content

fix apikit#4

Merged
KARTIKrocks merged 1 commit intomainfrom
fix-apikit
Feb 23, 2026
Merged

fix apikit#4
KARTIKrocks merged 1 commit intomainfrom
fix-apikit

Conversation

@KARTIKrocks
Copy link
Owner

Fixed

  • request — Race condition on globalConfig and globalPaginationConfig — added sync.RWMutex guards
  • middleware — Logger responseWriter forwarded duplicate WriteHeader calls to underlying writer
  • middlewareRetry-After header was hardcoded to "60" regardless of configured rate limit window
  • middlewareitoa helper caused infinite recursion on math.MinInt — replaced with strconv.Itoa
  • httpclient — Integer overflow in retry delay calculation when attempt count exceeded 62
  • httpclient — Circuit breaker allowed multiple concurrent probes in half-open state (TOCTOU)
  • responseFile() Content-Disposition header injection on non-ASCII filenames — added RFC 5987 encoding
  • serverShutdown() returned immediately instead of waiting for graceful shutdown to complete
  • requestIsValidEmail accepted display-name formats like "Alice" <a@b.com> — now requires bare address
  • apitestRequestBuilder.Build() used Header.Set in loop, dropping multi-value headers — changed to Header.Add

@KARTIKrocks KARTIKrocks self-assigned this Feb 23, 2026
@KARTIKrocks KARTIKrocks merged commit 916383c into main Feb 23, 2026
3 checks passed
@KARTIKrocks KARTIKrocks deleted the fix-apikit branch February 23, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant