Don't show an image in the remote view for unexposed QtQuick windows#1113
Merged
Conversation
6 tasks
redstrate
force-pushed
the
work/josh/minimize-qtquick-fix
branch
from
278a5fe to
89be04a
Compare
Contributor
|
are tests passing for you locally ? |
The window isn't rendering when it isn't exposed, and that also means interacting with the remote view looks frozen/buggy (AKA not a great user experience!) We now listen to the window's expose events, and clear the image to prevent interaction. I didn't have to modify the unavailable placeholder text either, because it already mentions that the window being minimized is a reason why the remote view is unavailable! This is implemented in the AbstractScreenGrabber class, so it works for all pre-existing screen grabbers and any future ones automatically.
Even if the remote view was unavailable for whatever reason, it was possible to pan it. This results in a *very* confused user (me, usually) when the remote view comes back online.
redstrate
force-pushed
the
work/josh/minimize-qtquick-fix
branch
from
89be04a to
c066091
Compare
Contributor
Author
No I think the CI is correct, I was missing a null check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window isn't rendering when it isn't exposed, and that also means
interacting with the remote view looks frozen/buggy (AKA not a great
user experience!)
We now listen to the window's expose events, and clear the image to
prevent interaction. I didn't have to modify the unavailable placeholder
text either, because it already mentions that the window being minimized
is a reason why the remote view is unavailable!
This is implemented in the AbstractScreenGrabber class, so it works for
all pre-existing screen grabbers and any future ones automatically.
I also implemented another change to prevent users from panning an unavailable remote view.