Docs: brace multi-line bodies; state the exhaustive-switch rule generally#10
Merged
Conversation
…ally Brace a loop/conditional body unless it's a true one-liner. And state the no-default-arm switch rule generally in Naming and style (it was only in the error-mapping rule 5, though .editorconfig already enforces it via CS8509=error). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The braces rule that came out of reviewing the hampap
local-data-snapshotimporter, plus a general statement of the switch rule this repo already enforces.Naming and style — added
default/discard arm in aswitchover an enum or a type we own — stated generally (it was only in the error-mapping rule 5). Already enforced:.editorconfighasCS8509.severity = error, so no config change here.Fresh from
main; the restructure PR #8 rewrites this sameCLAUDE.md, so whichever merges second needs a rebase.🤖 Generated with Claude Code