ADRs are living documents; consolidate to one ADR per aspect#7
Merged
Conversation
Fold the single-project decision back into ADR-0001 and delete ADR-0009: an ADR is rewritten in place when its decision changes (git holds the history), never marked superseded or replaced by a new number. The rule is stated in docs/adr/README.md and CLAUDE.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
One aspect, one ADR: 0001 now carries the whole feature-slice story (layout, controllers, Result error enums, DTO layer); 0002 carries the whole constraint pipeline (strong types -> EF -> OpenAPI -> generated frontend client). 0003 and 0004 are deleted; numbers are identity, so the gaps stay. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KaliCZ
changed the title
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the corrected ADR policy on top of #6 (stacked PR — GitHub retargets when #6 merges), and consolidates the overlapping ADRs.
The rule
ADRs are the up-to-date description of the current design — never a numbered history of decisions. When a decision changes, its ADR is rewritten in place, in the same PR, to state the new thinking; git holds the history. No "superseded" statuses, no new number for a changed decision — new numbers are only for aspects no existing ADR covers, and numbering stays compact: removing or merging an aspect renumbers the rest. A rolled-back approach usually earns a line under "Alternatives considered".
Stated in docs/adr/README.md (the hard rules up top) and in CLAUDE.md ("Read the design first").
Applied
Result+ per-operation error enums, controllers map them exhaustively to HTTP, DTO layer, proof-of-loading reads. The abandoned two-project split and exceptions-for-business-failures live under Alternatives considered.Final set: 0001 (slices + errors), 0002 (types + contract), 0003 (auth), 0004 (seeding), 0005 (real-dependency tests), 0006 (Vue SPA).
Docs + comments only; build stays at 0 warnings.
🤖 Generated with Claude Code