Set OpenGL_GL_Preference to LEGACY#3
Open
scchow wants to merge 1 commit into
Open
Conversation
- OpenGL_GL_Preference requires either LEGACY or GLVND without quotation marks. - Currently, on compilation, CMake warns that OpenGL_GL_Preference is unset and defaults to LEGACY. - Set OpenGL_GL_Preference to LEGACY to ensure same behavior as before, even though the code intent seems to be to set it to GLVND.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
OpenGL_GL_Preferencerequires eitherLEGACYorGLVNDwithout quotation marks.Currently, when building
roscpp_gl_depth_sim_demos(after #2 is applied), CMake warns thatOpenGL_GL_Preferenceis unset and defaults toLEGACYsince it does not recognize"GLVND".In this PR, I have set
OpenGL_GL_PreferencetoLEGACYwhich should preserve the same behavior as before, even though the intent seems to be to set it toGLVND.Please let me know if I should amend the PR to set the preference to
GLVND.