Fix dependabot PR: move Aspire.AppHost.Sdk version to global.json#43
Merged
Conversation
…k it Agent-Logs-Url: https://github.com/Keboo/GillyTracker/sessions/55bca66b-4c7f-42d4-a0b3-79d40c63ef95 Co-authored-by: Keboo <952248+Keboo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot PR #3 failed CI with:
Root cause:
GillyTracker.AppHost.csprojhardcodes theAspire.AppHost.Sdkversion inline (<Project Sdk="Aspire.AppHost.Sdk/13.3.5">). Dependabot cannot update this format — it only updatesDirectory.Packages.props,.config/dotnet-tools.json, andglobal.json. So when dependabot bumped packages to 13.3.3, the SDK stayed behind at 13.2.0, causing the DCP runtime version check to fail.Changes
global.json: Addedmsbuild-sdkssection with"Aspire.AppHost.Sdk": "13.3.5". Dependabot tracks this section for nuget updates, so future bumps will keep the SDK in sync with packages.GillyTracker.AppHost/GillyTracker.AppHost.csproj: Removed inline version from SDK reference (Aspire.AppHost.Sdk/13.3.5→Aspire.AppHost.Sdk). Version is now resolved fromglobal.json.Testing
global.jsonCloses #3