Fix: sync spinner corrupting large console output (garbled KSM config tokens)#2141
Merged
Merged
Conversation
…) + validate generated KSM config
sk-keeper
pushed a commit
that referenced
this pull request
Jun 13, 2026
…) + validate generated KSM config (#2141)
sk-keeper
pushed a commit
that referenced
this pull request
Jun 13, 2026
…) + validate generated KSM config (#2141)
jpkeepersecurity
pushed a commit
that referenced
this pull request
Jul 3, 2026
…) + validate generated KSM config (#2141)
pvagare-ks
pushed a commit
that referenced
this pull request
Jul 16, 2026
…) + validate generated KSM config (#2141)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sync_down"Syncing..." spinner (a daemon thread writing\r-prefixed frames to stdout) could keep ticking after it should have stopped and overwrite rows of later output. Whenpam project importprinted its base64 gateway config, this rarely corrupted the token - valid base64, broken JSON inside.Two triggers:
spinner.stop()was not in afinally, so any exception during sync leaked the thread for the rest of the session; and the stop path raced console writes (frame/clear landing on freshly printed output).