Skip to content

KC-1342: Fix pam config list dropping seconds from 6-part Quartz CRON #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craiglurey merged 1 commit into from
Jul 7, 2026
Merged

KC-1342: Fix pam config list dropping seconds from 6-part Quartz CRON #2192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions keepercommander/vault.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,7 @@ def export_schedule_field(value): # type: (dict) -> Optional[str]
cron = value.get('cron')
if isinstance(cron, str):
comps = [x for x in cron.split(' ') if x]
if len(comps) >= 6:
comps = comps[1:6]
if comps:
return ' '.join(comps)
return ''

Expand Down
10 changes: 10 additions & 0 deletions unit-tests/test_importer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,13 @@ def test_schedule_parser(self):
self.assertEqual(sc.get('type'), 'MONTHLY_BY_WEEKDAY')
self.assertEqual(sc.get('weekday'), 'WEDNESDAY')
self.assertEqual(sc.get('occurrence'), 'SECOND')

def test_export_schedule_field_preserves_quartz_cron_seconds(self):
schedule = {"type": "CRON", "cron": "1 5 1 * * ?", "tz": "Etc/UTC"}
self.assertEqual(vault.TypedField.export_schedule_field(schedule), '1 5 1 * * ?')

schedule = {"type": "CRON", "cron": "0 5 1 * * ?"}
self.assertEqual(vault.TypedField.export_schedule_field(schedule), '0 5 1 * * ?')

schedule = {"type": "CRON", "cron": "5 1 * * ?"}
self.assertEqual(vault.TypedField.export_schedule_field(schedule), '5 1 * * ?')
Loading