KC-1346: Fix misleading communication error when assigning team to admin role#2209
Merged
Conversation
sali-ks
approved these changes
Jul 13, 2026
pvagare-ks
approved these changes
Jul 14, 2026
amangalampalli-ks
approved these changes
Jul 14, 2026
sshrushanth-ks
added a commit
that referenced
this pull request
Jul 16, 2026
…min role (#2209) * Fix misleading communication error when assigning team to admin role * fixed unit test file * removed team details from response after warning is displayed
sk-keeper
pushed a commit
that referenced
this pull request
Jul 16, 2026
…min role (#2209) * Fix misleading communication error when assigning team to admin role * fixed unit test file * removed team details from response after warning is displayed
sk-keeper
pushed a commit
that referenced
this pull request
Jul 16, 2026
…min role (#2209) * Fix misleading communication error when assigning team to admin role * fixed unit test file * removed team details from response after warning is displayed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enterprise-team -ar showed the correct admin-role validation message but then also raised a misleading communication error. The API was still called with an empty RoleTeams payload after validation filtered out admin roles. This fix skips the API call when there are no role-team entries to send.
Changes