Reporting command implementation(Audit, Action and Password).#180
Merged
ukumar-ks merged 6 commits intoJul 1, 2026
Merged
Conversation
ukumar-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
ukumar-ks
requested review from
sali-ks and
sgaddala-ks
and removed request for
THeflinKeeper,
saldoukhov and
tylerccarson
ukumar-ks
changed the title
sali-ks
reviewed
Jun 25, 2026
sali-ks
reviewed
Jun 25, 2026
sali-ks
reviewed
Jun 25, 2026
| daysSince, | ||
| applyAction, | ||
| dryRun, | ||
| force, |
There was a problem hiding this comment.
force option is defined but never implemented
sali-ks
reviewed
Jun 25, 2026
| occurrences?: number | ||
| first_created?: number | string | ||
| last_created?: number | string | ||
| [key: string]: string | number | boolean | undefined |
There was a problem hiding this comment.
The index signature weakens type safety for known fields. Consider Record<string, unknown> for extras or a separate raw bag.
sali-ks
reviewed
Jun 25, 2026
| if (policy.digits > 0) parts.push(`digits >= ${policy.digits}`) | ||
| if (policy.special > 0) parts.push(`special >= ${policy.special}`) | ||
| return parts.join(', ') | ||
| } |
There was a problem hiding this comment.
Refactor this
export function buildPasswordPolicySummary(policy: PasswordPolicy): string {
return POLICY_SUMMARY_LABELS.filter(({ key }) => policy[key] > 0)
.map(({ key, label }) => `${label} >= ${policy[key]}`)
.join(', ')
}
There was a problem hiding this comment.
declare POLICY_SUMMARY_LABELS like
const POLICY_SUMMARY_LABELS: ReadonlyArray<{ key: keyof PasswordPolicy; label: string }> = [
{ key: 'length', label: 'length' },
{ key: 'lower', label: 'lowercase' },
{ key: 'upper', label: 'uppercase' },
{ key: 'digits', label: 'digits' },
{ key: 'special', label: 'special' },
]
sali-ks
reviewed
Jun 25, 2026
sali-ks
approved these changes
Jun 26, 2026
sgaddala-ks
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.