NSF remaining commands#210
Open
sgaddala-ks wants to merge 1 commit into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
sgaddala-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
|
|
||
| /** API transferRecordStatus success value for records_transfer_v3. */ | ||
| export enum NsfTransferApiStatus { | ||
| Success = 'success', |
Contributor
There was a problem hiding this comment.
This is apparently incorrect-- the success string for vault/records/v3/transfer is transfer_record_success.
Links:
https://keeper.atlassian.net/wiki/spaces/KA/pages/2767355905/records_ownership_transfer#TransferRecordStatus
https://keeper.atlassian.net/wiki/spaces/KA/pages/4214587476/Record+Ownership+Change
|
|
||
| try { | ||
| const statusList = await executeShareBatch(auth, request, statusField) | ||
| for (let itemIndex = 0; itemIndex < built.length; itemIndex++) { |
Contributor
There was a problem hiding this comment.
Not safe to assume order out here is the same as the order in.
Better to match the each entry to the corresponding item in the request by recordUid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Commands for