feat: [뭉치 만들기] - 2 키링 선택 시트#52
Merged
Hidden character warning
The head ref may contain hidden characters: "feature/-\ubb49\uce58-\ub9cc\ub4e4\uae30-2-\ud0a4\ub9c1-\uc120\ud0dd-\uc2dc\ud2b8-\uc644\uc131\ubdf0"
Merged
Conversation
(아니 왜 수정뷰는 익스텐션 잘되어있는데, 생성뷰는 뭉쳐있노) - BundleCreateView를 BundleEditView와 동일한 익스텐션 구조로 분리 - +SelectSheet, +Alert, +Purchase, +Initialization, +Capture - BundleEditView+Capture.swift 추가 (캡처 로직 분리) - BundleEditView+RestoreSelection.swift 삭제 (ViewModel로 이동) - BundleEditView.swift에서 중복 캡처 코드 제거
- BundleSearchBar, KeyringEmptyStateView, KeyringSelectionContent를 Shared로 추출 - Edit의 키링 시트를 Create와 동일한 SwiftUI sheet 방식으로 변경
- 1순위: 현재 위치에 장착된 키링 - 2순위: 다른 위치에 장착된 키링들 - 다른 장착된 키링 선택 시, 시트가 내려가지 않고 해제됨. - 현재 위치의 키링값이 바뀌어야 시트가 닫힌다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 PR 내용
📱 스크린샷 (UI 변경 시)
-.MP4
해당 자리의 키링에 변화가 생겼을 때만 시트가 내려감
뭉치 완성뷰 공수가 커서, 피벗합니다.
🔗 관련 이슈
✅ 체크리스트