style: [에셋] - 숏로딩 gif 크기 및 케이스 수정#9
Merged
Hidden character warning
The head ref may contain hidden characters: "style/\uc5d0\uc14b---\ub85c\ub529-gif-\ud06c\uae30-\uc218\uc815"
Conversation
- 본 커밋은 short40을 적용한 뷰만 묶은 커밋입니다.
jini-coding
approved these changes
Jan 20, 2026
Member
jini-coding
left a comment
There was a problem hiding this comment.
단순하지만 엄청난 노동이었군여.. 일일이 바꾸느라 정말 고생하셨습니다👍
|
|
||
| enum LoadingType { | ||
| case short | ||
| case short30 |
Member
There was a problem hiding this comment.
개인적으로 short30, short40 보다는 피그마에서처럼 shortS, shortM이 좀 더 사용하기엔 직관적인 것 같지만
개발자(?) 입장에서 어떻게 보면 단순하게 크기가 30, 40이니까 이것도 좋네요. 통과ㅎㅎㅎ
Member
|
short60 추가 가능한가욤?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 PR 내용
기존 LoadingAlert의 .short 타입을 .short30과 .short40으로 분리하여 일관된 사이즈 시스템을 적용했습니다.
- short30: 30pt (작은 셀/썸네일용)
- short40: 40pt (일반 로딩용)
기존에 scaleEffect()로 임의 조정하던 방식을 제거하고, 명시적인 타입으로 관리합니다.
수정된 파일
LoadingAlert.swift: LoadingType enum 수정로딩 사용처 전체 목록
🏠 홈
🎪 페스티벌
📦 보관함
🎨 공방
✨ 키링 제작
🎁 뭉치
👋 온보딩
🔗 관련 이슈
✅ 체크리스트