Conversation
src/inject.js
Outdated
| injectStyleOnce(className, `.${className}`, | ||
| validDefinitions.map(d => d._definition), | ||
| useImportant, selectorHandlers); | ||
| const className = `${classNameBits.join("-o_O-")}` |
There was a problem hiding this comment.
This doesn't need to be in a template string, right?
src/inject.js
Outdated
| const validDefinitions = styleDefinitions.filter((def) => def); | ||
|
|
||
| let classNameBits = []; | ||
| let definitionBits = []; |
There was a problem hiding this comment.
These can be const, right?
There was a problem hiding this comment.
Oh yes, of course.
| classNameBits.push(styleDefinitions[i]._name); | ||
| definitionBits.push(styleDefinitions[i]._definition); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: 4 space indents, please
There was a problem hiding this comment.
gah! Would you be opposed to me setting up eslint to tell me about these things for this project?
There was a problem hiding this comment.
Hahaha not at all, I was thinking the same thing. We have eslint but it doesn't have much turned on. :P I think ideally it would follow the KA style eslint at https://github.com/Khan/khan-linter/blob/master/eslintrc but that's ginormous so maybe just adding in a few of the common annoying ones would be good...
This function is called every time css() is used, so we want it to be as fast as possible. I spotted three loops here that could be condensed into one. In my profiling this seems to make the function about 30% faster.
lencioni
force-pushed
the
injectandgetclassname
branch
from
e2c558e to
4199188
Compare
|
Updated! |
|
Mmkay, gonna go make the release now. Wish me luck! |
2 participants
This function is called every time css() is used, so we want it to be as
fast as possible. I spotted three loops here that could be condensed
into one. In my profiling this seems to make the function about 30%
faster.