Update SimpleSkin to place the parent bone at the origin.#335
Update SimpleSkin to place the parent bone at the origin.#335
Conversation
e329eac to
a01b429
Compare
|
(Sorry, I had written my latest comment in the linked PR before I saw this PR here). I still wonder how it can be justified that the root/parent node does not have a translation. I.e. if the parent bone had a length of 2.0, would a translation of (0,2,0) be stored in the child node? That seems strange.
Even if the parent has a translation of (0,1,0), it is still at the origin (only everything that is attached to it would not be). But maybe this can be sorted out in the other PR. |
|
Based on the dicussion in the linked issue, I think that this could be merged. (Or I could create a similar PR, and update the data layout images at https://github.com/KhronosGroup/glTF-Sample-Models/tree/a01b42951ed199597936330ada30bfa4a41c2d05/2.0/SimpleSkin#data-layout accordingly...) |
|
@javagl Yes, it looks like KhronosGroup/glTF-Tutorials#64 and this PR are in agreement currently. Do you want to merge this one? Or should we hold for an updated diagram? |
|
I'll to the final wording tweaks in the other PR and post a notification when ready (not later than during the weekend). Creating the updated diagrams is simple (as in |
|
If you can just add them to this branch, that sounds easiest. Thanks! |
|
Thanks @javagl! |

@javagl This is my attempt at fixing KhronosGroup/glTF-Tutorials#44.
Currently this model's two bones share the same location. This is visible by importing into Blender, although the orientation of both nodes is shown incorrectly. Blender can't correctly guess the bones' primary axis, due to them being colocated.
Simple_Previous.mp4
This PR moves the
translationand its associatedinverseBindMatrixsuch that one of the two nodes is positioned at the origin. Blender's import gets this one correct, because it presumes the child has moved to the end of the parent bone. But more importantly, the parent bone really is placed at the origin now.Simple_Good.mp4