Add Buildcheck events support + BuildSubmissionStarted#797
Conversation
|
Ping me when this is ready for review! |
|
@KirillOsenkov , it's ready for review, please take a look! |
|
We should also update our copy of the Writer here: It's rarely used (and maybe we should delete it?) but that's a separate conversation I think @JanKrivanek if you could review this PR too when you get a chance. Also didn't we want to write down some instructions on updating the viewer copy of the reader/writer? I can't remember if we already have these somewhere or whether we still need to do it. Appreciate the help @YuliiaKovalova! |
|
Writer is needed - it's used for redacting functionality. Documenting the viewer updating steps is as well still needed - I still didn't get a chance to fix it dotnet/msbuild#10146 I'll surely and gladly review this - great thanks @YuliiaKovalova for adding all the missing types!! |
| var fields = ReadBuildEventArgsFields(readImportance: true); | ||
| var rawTracingData = ReadStringDictionary() ?? new Dictionary<string, string>(); | ||
|
|
||
| var e = new BuildCheckTracingEventArgs(rawTracingData.ToDictionary( |
There was a problem hiding this comment.
Is this class already known to viewer?
There was a problem hiding this comment.
|
Just needs the writer changes. |
|
Also do we have a unit-test like BinaryLoggerRoundtrip that reads and writes the same file? I think we do have something... Would be nice to make sure we didn't "forget" the writer changes somehow. |
We have this class:https://github.com/dotnet/msbuild/blob/5c934f81bcdf63168050f7083c4fd5b09faab9cc/src/Build.UnitTests/BuildEventArgsSerialization_Tests.cs but I see some missed recent events. |
|
Thanks! |
3 participants
Fixes #796
Context
Add BuildCheck events (dotnet/msbuild@ac76b77#diff-d88dc5683a31c5508ad8efa3aeecdfb56949fe6c0d234ff233afee954f93deb6) support and BuildSubmissionStarted (dotnet/msbuild#10424)