COMP: Fix unit tests for OpenCV 4#5
Closed
nocnokneo wants to merge 1 commit into
Closed
Conversation
nocnokneo
commented
Jan 14, 2020
| std::map<int, int> matDepthToIplDepth{ { CV_8U, IPL_DEPTH_8U }, { CV_8S, IPL_DEPTH_8S }, | ||
| { CV_16U, IPL_DEPTH_16U }, { CV_16S, IPL_DEPTH_16S }, | ||
| { CV_32S, IPL_DEPTH_32S }, { CV_32F, IPL_DEPTH_32F }, | ||
| { CV_64F, IPL_DEPTH_64F } }; |
Author
There was a problem hiding this comment.
FYI - I had to bypass the pre-commit hooks to avoid:
Modules/Video/BridgeOpenCV/test/itkOpenCVTestHelper.cxx:40: error: Unnecessary semicolon
pre-commit hook failure
-----------------------
KWStyle check failed.
Member
|
The PRs should be made against https://github.com/InsightSoftwareConsortium/ITK. https://github.com/Kitware/ITK is only a mirror. |
Author
|
Whoops, closing this in lieu of InsightSoftwareConsortium#1591 |
kwrobot
pushed a commit
that referenced
this pull request
May 5, 2026
Two upstream bugs caught by Greptile review on PR InsightSoftwareConsortium#6214: 1. WritePointData() printed to std::cerr and returned silently when m_PointPixelComponentType was UNKNOWNCOMPONENTTYPE, leaving the output file in a partially-written state. Replace with itkExceptionMacro so the failure surfaces to the caller. 2. ~MZ3MeshIO() never closed m_Ofstream — a write that threw between WriteMeshInformation()'s open and Write()'s explicit close leaked the output stream. Close both m_Ifstream and m_Ofstream in the destructor's uncompressed branch (guarded by is_open() so closing twice is safe). Also rewrites the 20 C-style (char *)& casts on gzread / gzwrite / ifstream / ofstream calls to reinterpret_cast<char *>(&...) per ITK style guide (Greptile P2 #6). Also fixes the WriteCells CHAR case that cast the buffer to unsigned char * instead of char *, which would silently corrupt negative vertex indices on signed cell-component types (Greptile P2 #5).
kwrobot
pushed a commit
that referenced
this pull request
May 15, 2026
Merge ITKBinaryThinning3D into master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes InsightSoftwareConsortium#806
PR Checklist