Image enhancements#1200
Merged
Merged
Conversation
subdavis
suggested changes
Mar 28, 2022
| {blackPoint?: number; whitePoint?: number }) => { | ||
| VueSet(imageEnhancements.value, 'blackPoint', blackPoint); | ||
| VueSet(imageEnhancements.value, 'whitePoint', whitePoint); | ||
| markChangesPending(); |
Contributor
There was a problem hiding this comment.
This composition function should not call markChangesPending. There's nothing to save. It should probably not take it as a param.
Collaborator
Author
There was a problem hiding this comment.
🤦 - I was in the middle of adding saving of the metadata, and I must have forgot to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1197
I added in a small basic image enhancement to modify the filter on SVG filter.
I added a context menu because I have a feeling these effects might expand in the future beyond just doing contrast adjustments. I guess it could be a small pop-up like the playback speed, but I'm guessing that we want to add more stuff in the future to this.
Image/Video Annotators have been modified to accepting an intercept as well as a brightness setting. So you can adjust both to adjust the brightness and contrast of the image.
I created
useImageEnhancments.tswith the idea that in the future the image enhancements may be more complex with more data being transferred. That's also why it acceptsmarkChangesPending, so that the setting could be saved in the future for the dataset metadata.