Button to boost confidence to 1.0#1209
Conversation
subdavis
changed the title
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
One small (probably insignificant) question, but otherwise it seems to do what is needed and we know that in the future we may need some shortcuts to make this more useful.
| {{ pair[1].toFixed(4) }} | ||
| </v-col> | ||
| <v-col | ||
| v-if="pair[1] !== 1 && !disabled" |
There was a problem hiding this comment.
Just wondering if this should be shown if the pair length > 1 or if the pair[1] !== 1. I know the idea of the confidencePairs means this should never be 1.0 while also having other pairs but if anyone reformatted their CSV to have a 1.0 pair and other pairs they wouldn't be able to use this quick tool to assign a true pair. It's a small thing and probably don't worry about it too much.
There was a problem hiding this comment.
I guess it depends on what you care about. If a pair already has a value of 1.0 then maybe it doesn't matter. Likewise, if there's only one pair, but it's 0.25, maybe someone would want to make it 1.0.
We can always change it later if someone has a preference.
2 participants
fixes #1202
This is the easy/obvious solution I could add quickly to give the user something that worked. There may be a more ergonomic version that accepts the current top confidence as correct from the track list, but I didn't do that because there's no way to show the user feedback that this has done something, and adding visual feedback will require a bit more thought.
We'll need a way to display on a track list item where
confidence == 1or not, and then a button or hotkey or something to boost it to 1. This is related to #614.I think this PR is a minimal fix that will give users something to provide feedback on.