Skip to content

In devmode do not load dependencies of disabled packages #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
Dec 22, 2024
Merged

In devmode do not load dependencies of disabled packages #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion Knossos.NET/Models/Mod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,40 @@ public List<string> GetModFlagList(bool overrideSettings = false)
}
else
{
return modFlag;
if (!devMode)
{
return modFlag;
}
else
{
try
{
//Check if the modflag belongs to a disabled pkg, if so skip it if not enabled pkg also reffers it
var flagList = new List<string>();
foreach (var flag in modFlag)
{
var foundDisabled = packages.FirstOrDefault(d => !d.isEnabled && d.dependencies != null && d.dependencies.FirstOrDefault(dp => dp.id == flag) != null);

if (foundDisabled != null)
{
var foundEnabled = packages.FirstOrDefault(e => e.isEnabled && e.dependencies != null && e.dependencies.FirstOrDefault(ep => ep.id == flag) != null);
if (foundEnabled != null)
{
flagList.Add(flag);
}
}
else
{
flagList.Add(flag);
}
}
return flagList;
}catch(Exception ex)
{
Log.Add(Log.LogSeverity.Error, "Mod.GetModFlagList()", ex);
return modFlag;
}
}
}
}

Expand Down