Skip to content

Fix mod settings were not saving on newely installed mods until restart #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 2 commits into from
Jan 17, 2025
Merged

Fix mod settings were not saving on newely installed mods until restart #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bfde97
Fix mod settings were not saving on newely installed mods until restart
Shivansps Jan 15, 2025
d17c958
On second thought, do not call Mod Settings.Load() after a install
Shivansps Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Knossos.NET/Models/ModSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,16 @@ public bool IsDefaultConfig()
return true;
}

/// <summary>
/// Sets the filepath to the mod folder for the mod settings system, if it is not already set.
/// </summary>
/// <param name="modFullPath"></param>
public void SetInitialFilePath(string modFullPath)
{
if (filePath == null)
filePath = modFullPath + Path.DirectorySeparatorChar + "mod_settings.json";
}

/// <summary>
/// Load mod_settings.json data
/// Any new variabled must be added here or it will not be loaded
Expand Down
2 changes: 2 additions & 0 deletions Knossos.NET/ViewModels/Templates/Tasks/InstallMod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,8 @@ public async Task<bool> InstallMod(Mod mod, CancellationTokenSource cancelSource
mod.ClearUnusedData();
}

mod.modSettings.SetInitialFilePath(mod.fullPath);

//We have to compress?
if (compressMod)
{
Expand Down