Skip to content

Only check if files in cache are outdated once per session or reload#293

Merged
Shivansps merged 2 commits into
KnossosNET:mainfrom
Shivansps:cache-check-once
Feb 4, 2025
Merged

Only check if files in cache are outdated once per session or reload#293
Shivansps merged 2 commits into
KnossosNET:mainfrom
Shivansps:cache-check-once

Conversation

@Shivansps

Copy link
Copy Markdown
Member

This is not to constanly query remote url for file etags every time the file is requested, instead it will be done once per seccion or when the user click reload.

@Shivansps Shivansps added the cleanup Cleanup code or other aspect label Feb 3, 2025
Comment thread Knossos.NET/Classes/KnUtils.cs Outdated
Comment thread Knossos.NET/Classes/KnUtils.cs Outdated
@wookieejedi

Copy link
Copy Markdown
Contributor

Just 2 small comments about the comments, nothing impending a merge though

@wookieejedi

Copy link
Copy Markdown
Contributor

Thanks!

@wookieejedi wookieejedi added this to the 1.3 milestone Feb 4, 2025
@Shivansps Shivansps merged commit 87c6845 into KnossosNET:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleanup code or other aspect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants