Skip to content

Verify browser URL before opening (C1 Fix) #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
Apr 12, 2026
Merged

Verify browser URL before opening (C1 Fix) #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions Knossos.NET/Classes/KnUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,24 +349,31 @@ public static string GetOSNameString()
/// <param name="url"></param>
public static void OpenBrowserURL(string url)
{
// Check URL
if (string.IsNullOrWhiteSpace(url) || !Uri.TryCreate(url, UriKind.Absolute, out var uri) || (uri.Scheme != Uri.UriSchemeHttp && uri.Scheme != Uri.UriSchemeHttps))
{
Log.Add(Log.LogSeverity.Warning, "KnUtils.OpenBrowserURL", $"Not opening web browser link due to invalid or unsafe URL: {url}");
return;
}

try
{
using (var process = new Process())
{
if (IsWindows)
{
process.StartInfo.FileName = "cmd";
process.StartInfo.Arguments = $"/c start {url}";
process.StartInfo.FileName = uri.ToString();
process.StartInfo.UseShellExecute = true;
}
else if (IsLinux)
{
process.StartInfo.FileName = "xdg-open";
process.StartInfo.Arguments = url;
process.StartInfo.Arguments = uri.ToString();
}
else if (IsMacOS)
{
process.StartInfo.FileName = "open";
process.StartInfo.Arguments = url;
process.StartInfo.Arguments = uri.ToString();
}
process.StartInfo.CreateNoWindow = true;
process.Start();
Expand Down