Skip to content

Re-add crc check limit for preparepkg and check task cancelled (H10 fix) #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
Apr 12, 2026
Merged

Re-add crc check limit for preparepkg and check task cancelled (H10 fix) #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Knossos.NET/ViewModels/Templates/Tasks/PrepareModPkg.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ private async Task<bool> PrepareModPkg(ModPackage pkg, string modFullPath, Cance
IsTextTask = false;
IsFileDownloadTask = false;
Name = "Prepare Pkg: " + pkg.name;
//var maxCrcAttempts = 5; //How many times try to compress a pkg with 7z in case of CRC error (LIMIT DISABLED)
var maxCrcAttempts = 25; //How many times try to compress a pkg with 7z in case of CRC error

if (cancelSource != null)
cancellationTokenSource = cancelSource;
Expand Down Expand Up @@ -121,21 +121,22 @@ private async Task<bool> PrepareModPkg(ModPackage pkg, string modFullPath, Cance
crcResult = await compressor.VerifyFile(zipPath);
if (!crcResult)
{
/*
if(crcAttempt >= maxCrcAttempts)
{
Log.Add(Log.LogSeverity.Error, "TaskItemViewModel.PrepareModPkg()", "CRC error on file: " + zipPath + ". Max attempts reached, cancelling upload...");
throw new TaskCanceledException();
}
*/
Log.Add(Log.LogSeverity.Error, "TaskItemViewModel.PrepareModPkg()", "CRC error on file: " + zipPath + ". Retrying...");
ProgressBarMax = 100;
ProgressCurrent = 0;
Info = "Retry: Compressing (7z)";
KnUtils.DeleteFileSafe(zipPath);
crcAttempt++;
await Task.Delay(1000);
}
}
if (cancellationTokenSource.IsCancellationRequested)
throw new TaskCanceledException();
} while (!crcResult);
Log.Add(Log.LogSeverity.Information, "TaskItemViewModel.PrepareModPkg()", "CRC Verify OK on File: " + zipPath);
}
Expand Down