Skip to content

Parallel.ForEachAsync Doesn't Wire CancellationToken (M15 fix) #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
Apr 12, 2026
Merged

Parallel.ForEachAsync Doesn't Wire CancellationToken (M15 fix) #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Knossos.NET/ViewModels/Templates/Tasks/InstallBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public partial class TaskItemViewModel : ViewModelBase
-Increase main progress when:
File starts to download, File finishes downloading, Decompression starts, Decompression ends, Image download completed
*/
await Parallel.ForEachAsync(files, new ParallelOptions { MaxDegreeOfParallelism = Knossos.globalSettings.maxConcurrentSubtasks }, async (file, token) =>
await Parallel.ForEachAsync(files, new ParallelOptions { MaxDegreeOfParallelism = Knossos.globalSettings.maxConcurrentSubtasks, CancellationToken = cancellationTokenSource.Token }, async (file, token) =>
{
if (cancellationTokenSource.IsCancellationRequested)
{
Expand Down
2 changes: 1 addition & 1 deletion Knossos.NET/ViewModels/Templates/Tasks/InstallMod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ public async Task<bool> InstallMod(Mod mod, CancellationTokenSource cancelSource
File starts to download, File finishes downloading, Decompression starts, Decompression ends, Image download completed
*/
mod.fullPath = modPath + Path.DirectorySeparatorChar;
await Parallel.ForEachAsync(files, new ParallelOptions { MaxDegreeOfParallelism = Knossos.globalSettings.maxConcurrentSubtasks }, async (file, token) =>
await Parallel.ForEachAsync(files, new ParallelOptions { MaxDegreeOfParallelism = Knossos.globalSettings.maxConcurrentSubtasks, CancellationToken = cancellationTokenSource.Token }, async (file, token) =>
{
if (cancellationTokenSource.IsCancellationRequested)
{
Expand Down