Guard async void TaskViewModel methods against unhandled exceptions#401
Merged
Conversation
InstallMod, VerifyMod, CreateModVersion, and UploadModVersion were async void with no top-level exception handling. Any exception escaping after an await would be posted to the SynchronizationContext as unhandled, silently crashing the process — no global handler is registered anywhere in the codebase. Wrap each method body in a try/catch that logs via Log.Add, matching the pattern already used in Knossos.StartUp and Knossos.PlayMod. No callers need to change; the fire-and-forget pattern is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Shivansps
approved these changes
May 6, 2026
Contributor
|
Things still work as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstallMod, VerifyMod, CreateModVersion, and UploadModVersion were async void with no top-level exception handling. Any exception escaping after an await would be posted to the SynchronizationContext as unhandled, silently crashing the process — no global handler is registered anywhere in the codebase.
Wrap each method body in a try/catch that logs via Log.Add, matching the pattern already used in Knossos.StartUp and Knossos.PlayMod. No callers need to change; the fire-and-forget pattern is preserved.