Skip to content

fix task cancellation #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivansps merged 1 commit into from
May 10, 2026
Merged

fix task cancellation #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Knossos.NET/ViewModels/Templates/Tasks/InstallBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ private async Task<bool> InstallVCRedist(bool is86 = false) {
{
Log.Add(Log.LogSeverity.Error, "TaskItemViewModel.InstallBuild()", $"Unsafe dest path in build '{build.id}': {file.dest}");
CancelTaskCommand();
return null;
}
Directory.CreateDirectory(modPath + Path.DirectorySeparatorChar + file.dest);
}
Expand Down Expand Up @@ -359,6 +360,7 @@ private async Task<bool> InstallVCRedist(bool is86 = false) {
{
Log.Add(Log.LogSeverity.Error, "TaskItemViewModel.InstallBuild()", "Error while decompressing the file " + fileFullPath);
CancelTaskCommand();
throw new TaskCanceledException();
}
//sender.ProgressBarCurrent = ++ProgressCurrent;
++ProgressCurrent;
Expand Down
1 change: 1 addition & 0 deletions Knossos.NET/ViewModels/Templates/Tasks/InstallMod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ public async Task<bool> InstallMod(Mod mod, CancellationTokenSource cancelSource
{
Log.Add(Log.LogSeverity.Error, "TaskItemViewModel.InstallMod()", "Error while decompressing the file " + fileFullPath);
CancelTaskCommand();
throw new TaskCanceledException();
}
File.Delete(fileFullPath);
++ProgressCurrent;
Expand Down
1 change: 1 addition & 0 deletions Knossos.NET/ViewModels/Templates/Tasks/InstallTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public async Task<bool> InstallTool(Tool tool, Tool? updateFrom, Action<bool> fi
{
Log.Add(Log.LogSeverity.Error, "TaskItemViewModel.InstallTool()", "Error while decompressing the file " + fileFullPath);
CancelTaskCommand();
throw new TaskCanceledException();
}

if (cancellationTokenSource.IsCancellationRequested)
Expand Down