Use dependency injection - #188
Merged
Merged
Conversation
getting the dictionary through DI is a better practice that getting it from the container.
tacman
requested review from
AntoineLelaisant and
PedroTroller
as code owners
December 4, 2022 13:55
Contributor
Author
|
Any comments on this PR? |
PedroTroller
approved these changes
Jan 17, 2023
Contributor
|
I'm having trouble making time, sorry for the delay. |
PedroTroller
pushed a commit
that referenced
this pull request
May 25, 2023
getting the dictionary through DI is a better practice that getting it from the container.
PedroTroller
pushed a commit
that referenced
this pull request
Jun 15, 2023
* add return annotation To get rid of this warning: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Knp\DictionaryBundle\Dictionary\Traceable" now to avoid errors or add an explicit @return annotation to suppress this message. 1x in ImportYamlTest::testLoadYamlConfig with data set "oberon" from App\Tests\Service * docs: remove $ so gitclip works (#186) * Use dependency injection (#188) getting the dictionary through DI is a better practice that getting it from the container. * Allow Symfony 6.3 * refactor: remove support of php 7.4 * Add Symfony 6.2 to matrix (#183) * chore: drop support of Symfony 6.1 & 6.2 * tests: remove beberlei/assert and replace it by webmozart/assert (already in indirect dependencies) (#185) * fix: add missing Symfony 6.3 supported version constant * refactor: ad type to Dictionary ArrayAccess methods * ci: remove Symfony CLI security check (#194) * refactor: fix cs issues * ci: remove Symfony CLI security check * test: add tests for Symfony 6.3 and php 8.2 --------- Co-authored-by: Tac Tacelosky <tacman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getting the dictionary through DI is a better practice that getting it from the container.