Switch to PSR-17 and remove deprecated code - #888
Merged
Conversation
GrahamCampbell
marked this pull request as draft
June 28, 2020 19:02
GrahamCampbell
marked this pull request as ready for review
June 28, 2020 19:22
cs278
reviewed
Jul 1, 2020
GrahamCampbell
changed the title
acrobat
requested changes
Jul 3, 2020
acrobat
left a comment
acrobat
left a comment
Collaborator
There was a problem hiding this comment.
Can you also add an upgrade file so users have a summary on what was removed/changed and maybe add some info on what packages to remove/replace to move to the psr18 implementation from an existing setup. thanks!
acrobat
reviewed
Jul 3, 2020
Collaborator
|
Thanks for the work already @GrahamCampbell! Just a few comments/changes. |
Contributor
Author
|
Just rebased and applied changes based on the feedback. |
acrobat
approved these changes
Jul 4, 2020
Contributor
Author
|
@acrobat If you do another 2.x -> master merge, I'll rebase this PR again, so that you don't have additional merge conflicts in the authentication class later on. |
Collaborator
|
Upmerge is done! |
Co-authored-by: Chris Smith <github.com@chris.cs278.org>
Contributor
Author
|
Build green now. :) |
Collaborator
|
Thanks a lot for your work on this @GrahamCampbell! |
Contributor
Author
|
No problem. :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all the deprecated code from the codebase, and switches to PSR-17 which replaces the old PHP HTTP interfaces, just like PSR-18 replaced some of the others (implemented in an earlier PR).