Fix broken roave/bc-check test#890
Merged
Merged
Conversation
Contributor
|
I think this is breaking because the last release had a v on the front by mistake? |
acrobat
force-pushed
the
fix-roave-bc-check
branch
from
June 28, 2020 21:36
bde667f to
88e7a23
Compare
Collaborator
Author
|
No not by mistake, I switched to a cli tool to do the merges/releases etc and this tool tags versions with the |
Contributor
|
Ah, right. 👍 |
GrahamCampbell
approved these changes
Jun 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the bc-check was broken due to a changed tag format, which causes an incorrect version/tag to be guessed. This was fixed in 5.0