Skip to content

Show user by ID - #894

Merged
acrobat merged 4 commits into
KnpLabs:2.xfrom
genintho:genintho-user-by-id
Jul 4, 2020
Merged

Show user by ID#894
acrobat merged 4 commits into
KnpLabs:2.xfrom
genintho:genintho-user-by-id

Conversation

@genintho

@genintho genintho commented Jul 3, 2020

Copy link
Copy Markdown
Contributor

Revamp of #372 which was abandonned, and following the example of #579

As of 2020, gettting data by ID is still undocumented. I contacted Github support to make sure it could be relied on.

Screen Shot 2020-07-02 at 10 12 15 PM

I have been working with an old application and I have to deal with actions made by user that have changed their login since. The old login are now used by totally different people, which can be problematic.

Comment thread lib/Github/Api/User.php Outdated

@GrahamCampbell GrahamCampbell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. 🎉

@acrobat
acrobat merged commit 1c16592 into KnpLabs:2.x Jul 4, 2020
@acrobat

acrobat commented Jul 4, 2020

Copy link
Copy Markdown
Collaborator

Thanks @genintho! And congrats on your first contribution! 🎉

acrobat added a commit that referenced this pull request Jul 4, 2020
* 2.x:
  feature #894 Show user by ID (genintho)
  Don't urlencode integer values
  Fixed incorrect MissingArgumentException parent constructor values
  Removed shadow-cat
  minor #892 Don't use deprecated auth in examples (GrahamCampbell)
  Fix broken roave/bc-check test
  Update branch alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants