Skip to content

Move Heiman‑specific converters to local and leverage cluster definitions.#12076

Merged
Koenkk merged 17 commits intoKoenkk:masterfrom
svhelge:heiman
May 8, 2026
Merged

Move Heiman‑specific converters to local and leverage cluster definitions.#12076
Koenkk merged 17 commits intoKoenkk:masterfrom
svhelge:heiman

Conversation

@svhelge
Copy link
Copy Markdown
Contributor

@svhelge svhelge commented Apr 30, 2026

Move Heiman‑specific converters to local, improve typing for Heiman attributes, and leverage cluster definitions.
Refactor by extracting shared logic into heimanExtend.

Svhelge and others added 3 commits April 30, 2026 00:53
Improve typing for Heiman specific attributes and make use of the cluster definitions.
Improve typing for Heiman specific attributes and make use of the cluster definitions.
@svhelge svhelge changed the title Move Heiman Move Heiman‑specific converters to local and leverage cluster definitions. Apr 30, 2026
Comment thread src/devices/heiman.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Heiman device support by moving Heiman-specific converters out of the global converter registries into src/devices/heiman.ts, and updates several reads/exposes to use cluster attribute names/types instead of raw IDs.

Changes:

  • Moved Heiman IR remote / scenes / air-quality / doorbell converters into src/devices/heiman.ts (tzLocal/fzLocal) and removed them from src/converters/*.
  • Added helper methods to heimanExtend and switched several device definitions/configure reads to use cluster attribute names.
  • Adjusted heimanClusterSpecial attribute metadata (e.g., enabling writes for some WiFi/camera-related attributes).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
src/devices/heiman.ts Adds local Heiman converters and refactors multiple exposes/configure reads to use cluster attribute names and shared heimanExtend helpers.
src/converters/toZigbee.ts Removes global heiman_ir_remote toZigbee converter now that it is local to Heiman devices.
src/converters/fromZigbee.ts Removes global Heiman fromZigbee converters now that they are local to Heiman devices.

Comment thread src/devices/heiman.ts
Comment thread src/devices/heiman.ts Outdated
Comment thread src/devices/heiman.ts Outdated
Comment thread src/devices/heiman.ts Outdated
Comment thread src/devices/heiman.ts Outdated
Comment thread src/devices/heiman.ts
Comment thread src/devices/heiman.ts
@ArJay60
Copy link
Copy Markdown

ArJay60 commented May 5, 2026

Can you add CO detector HS1CA-E as by #30738. External converter at the bottom of @30738 works.

@svhelge
Copy link
Copy Markdown
Contributor Author

svhelge commented May 5, 2026

Can you add CO detector HS1CA-E as by #30738. External converter at the bottom of @30738 works.

I can create a PR for 30738 after this PR is merged.

@svhelge
Copy link
Copy Markdown
Contributor Author

svhelge commented May 5, 2026

@Koenkk , all Copilot comments resolved.

@Koenkk
Copy link
Copy Markdown
Owner

Koenkk commented May 6, 2026

I will create a hotfix release for the current Tuya issues, so will hold off this pr until then.

@Koenkk
Copy link
Copy Markdown
Owner

Koenkk commented May 7, 2026

Hot-fix release is out, could you fix the merge conflicts? Then this is ready

@Koenkk
Copy link
Copy Markdown
Owner

Koenkk commented May 8, 2026

Thanks!

@Koenkk Koenkk merged commit f819833 into Koenkk:master May 8, 2026
3 checks passed
@svhelge svhelge deleted the heiman branch May 8, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants