Move Heiman‑specific converters to local and leverage cluster definitions.#12076
Move Heiman‑specific converters to local and leverage cluster definitions.#12076Koenkk merged 17 commits intoKoenkk:masterfrom
Conversation
Improve typing for Heiman specific attributes and make use of the cluster definitions.
Improve typing for Heiman specific attributes and make use of the cluster definitions.
There was a problem hiding this comment.
Pull request overview
This PR refactors Heiman device support by moving Heiman-specific converters out of the global converter registries into src/devices/heiman.ts, and updates several reads/exposes to use cluster attribute names/types instead of raw IDs.
Changes:
- Moved Heiman IR remote / scenes / air-quality / doorbell converters into
src/devices/heiman.ts(tzLocal/fzLocal) and removed them fromsrc/converters/*. - Added helper methods to
heimanExtendand switched several device definitions/configure reads to use cluster attribute names. - Adjusted
heimanClusterSpecialattribute metadata (e.g., enabling writes for some WiFi/camera-related attributes).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/devices/heiman.ts | Adds local Heiman converters and refactors multiple exposes/configure reads to use cluster attribute names and shared heimanExtend helpers. |
| src/converters/toZigbee.ts | Removes global heiman_ir_remote toZigbee converter now that it is local to Heiman devices. |
| src/converters/fromZigbee.ts | Removes global Heiman fromZigbee converters now that they are local to Heiman devices. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Can you add CO detector HS1CA-E as by #30738. External converter at the bottom of @30738 works. |
I can create a PR for 30738 after this PR is merged. |
|
@Koenkk , all Copilot comments resolved. |
|
I will create a hotfix release for the current Tuya issues, so will hold off this pr until then. |
|
Hot-fix release is out, could you fix the merge conflicts? Then this is ready |
|
Thanks! |
Move Heiman‑specific converters to local, improve typing for Heiman attributes, and leverage cluster definitions.
Refactor by extracting shared logic into
heimanExtend.