Refactor Namron Thermostat Converters to Use Typed Cluster Definitions#12117
Merged
Koenkk merged 9 commits intoKoenkk:masterfrom May 8, 2026
Merged
Refactor Namron Thermostat Converters to Use Typed Cluster Definitions#12117Koenkk merged 9 commits intoKoenkk:masterfrom
Koenkk merged 9 commits intoKoenkk:masterfrom
Conversation
Owner
|
will merge after the hotfix release |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Namron thermostat handling by moving the namron_thermostat converter into the Namron library and switching it to typed attribute names backed by a device-added custom hvacThermostat cluster definition.
Changes:
- Added
namronExtend.addNamronHvacThermostatCluster()to register Namron/Sunricher manufacturer-specific thermostat attributes by name. - Moved
namron_thermostatfrom generic from/toZigbee converters intosrc/lib/namron.tsand updated affected device definitions to reference it. - Removed the legacy
namron_thermostatexports fromsrc/converters/fromZigbee.tsandsrc/converters/toZigbee.ts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib/namron.ts | Introduces typed hvacThermostat attribute definitions and hosts the moved Namron thermostat converters. |
| src/devices/sunricher.ts | Updates Sunricher thermostat definitions to use the Namron library converter and registers the custom thermostat cluster. |
| src/devices/namron.ts | Updates Namron thermostat definitions similarly and refactors the Simplify remote converter into fzLocal. |
| src/converters/toZigbee.ts | Removes the legacy tz.namron_thermostat converter from generic converters. |
| src/converters/fromZigbee.ts | Removes the legacy fz.namron_thermostat converter from generic converters. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
addNamronHvacThermostatCluster()extension that defines custom Namron HVAC thermostat attributes.Moved
namron_thermostatconverter from generic converters to the namron library with typed attributes.