Skip to content

Refactor Namron Thermostat Converters to Use Typed Cluster Definitions#12117

Merged
Koenkk merged 9 commits intoKoenkk:masterfrom
svhelge:namron
May 8, 2026
Merged

Refactor Namron Thermostat Converters to Use Typed Cluster Definitions#12117
Koenkk merged 9 commits intoKoenkk:masterfrom
svhelge:namron

Conversation

@svhelge
Copy link
Copy Markdown
Contributor

@svhelge svhelge commented May 5, 2026

Added addNamronHvacThermostatCluster() extension that defines custom Namron HVAC thermostat attributes.
Moved namron_thermostat converter from generic converters to the namron library with typed attributes.

@Koenkk Koenkk requested a review from Copilot May 6, 2026 19:17
@Koenkk
Copy link
Copy Markdown
Owner

Koenkk commented May 6, 2026

will merge after the hotfix release

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Namron thermostat handling by moving the namron_thermostat converter into the Namron library and switching it to typed attribute names backed by a device-added custom hvacThermostat cluster definition.

Changes:

  • Added namronExtend.addNamronHvacThermostatCluster() to register Namron/Sunricher manufacturer-specific thermostat attributes by name.
  • Moved namron_thermostat from generic from/toZigbee converters into src/lib/namron.ts and updated affected device definitions to reference it.
  • Removed the legacy namron_thermostat exports from src/converters/fromZigbee.ts and src/converters/toZigbee.ts.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/lib/namron.ts Introduces typed hvacThermostat attribute definitions and hosts the moved Namron thermostat converters.
src/devices/sunricher.ts Updates Sunricher thermostat definitions to use the Namron library converter and registers the custom thermostat cluster.
src/devices/namron.ts Updates Namron thermostat definitions similarly and refactors the Simplify remote converter into fzLocal.
src/converters/toZigbee.ts Removes the legacy tz.namron_thermostat converter from generic converters.
src/converters/fromZigbee.ts Removes the legacy fz.namron_thermostat converter from generic converters.

Comment thread src/lib/namron.ts Outdated
@Koenkk Koenkk merged commit 437e0e2 into Koenkk:master May 8, 2026
3 checks passed
@Koenkk
Copy link
Copy Markdown
Owner

Koenkk commented May 8, 2026

Thanks!

@svhelge svhelge deleted the namron branch May 8, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants