fix: bug where FormData in the js fetch target wasn't applied#202
Merged
reynolek merged 5 commits intoKong:masterfrom Apr 27, 2021
Merged
fix: bug where FormData in the js fetch target wasn't applied#202reynolek merged 5 commits intoKong:masterfrom
reynolek merged 5 commits intoKong:masterfrom
Conversation
|
Hey just wanted to check in on the status of this! I believe this is causing incorrect code to be generated in our ReadMe docs. |
Contributor
Author
|
@jbwyme You've already got this fix if you're a ReadMe customer because we run a fork (http://npm.im/@readme/httpsnippet) that have these changes. What's the bug you're seeing? |
|
Ah gotcha, perhaps this is unrelated. Here's the loom I shared with support: https://www.loom.com/share/06da93107f4b40f88172d680507ac99d |
Contributor
Author
|
@jbwyme Gotcha, that hit my desk yesterday. |
Contributor
|
Fixed merge conflict injected from the PR that removed node 8 |
reynolek
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchtarget whereFormDatawas being set to aformvariable but never actually inserted. into the body of the fetch call.headers.