fix(*): lazily initialize structures to avoid c-boundary errors on require#87
Merged
Conversation
…quire ### Summary Moves the code that was previously running on `module` level to `initialize` function that are lazily called when needed. This is to avoid the `yield accross C-boundary` errors during `require`.
hanshuebner
previously approved these changes
Sep 19, 2023
bungle
force-pushed
the
fix/c-boundary
branch
from
248c39a to
24de8e1
Compare
hanshuebner
approved these changes
Sep 19, 2023
bungle
added a commit
to Kong/kong
that referenced
this pull request
Sep 19, 2023
### Summary #### 1.3.5 (19-Sep-2023) - fix: lazily initialize structures to avoid c-boundary errors on require [87](Kong/lua-resty-aws#87) #### 1.3.4 (13-Sep-2023) - fix: remove more module-level uses of config.global [83](Kong/lua-resty-aws#83) #### 1.3.3 (13-Sep-2023) - fix: don't invoke region detection code on the module toplevel and advise against trying to. [81](Kong/lua-resty-aws#81) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Sep 19, 2023
### Summary #### 1.3.5 (19-Sep-2023) - fix: lazily initialize structures to avoid c-boundary errors on require [87](Kong/lua-resty-aws#87) #### 1.3.4 (13-Sep-2023) - fix: remove more module-level uses of config.global [83](Kong/lua-resty-aws#83) #### 1.3.3 (13-Sep-2023) - fix: don't invoke region detection code on the module toplevel and advise against trying to. [81](Kong/lua-resty-aws#81) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
windmgc
pushed a commit
to Kong/kong
that referenced
this pull request
Jan 24, 2024
- fix: lazily initialize structures to avoid c-boundary errors on require [87](Kong/lua-resty-aws#87) - fix: remove more module-level uses of config.global [83](Kong/lua-resty-aws#83) - fix: don't invoke region detection code on the module toplevel and advise against trying to. [81](Kong/lua-resty-aws#81) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
windmgc
pushed a commit
to Kong/kong
that referenced
this pull request
Mar 7, 2024
- fix: lazily initialize structures to avoid c-boundary errors on require [87](Kong/lua-resty-aws#87) - fix: remove more module-level uses of config.global [83](Kong/lua-resty-aws#83) - fix: don't invoke region detection code on the module toplevel and advise against trying to. [81](Kong/lua-resty-aws#81) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
windmgc
pushed a commit
to Kong/kong
that referenced
this pull request
Mar 8, 2024
- fix: lazily initialize structures to avoid c-boundary errors on require [87](Kong/lua-resty-aws#87) - fix: remove more module-level uses of config.global [83](Kong/lua-resty-aws#83) - fix: don't invoke region detection code on the module toplevel and advise against trying to. [81](Kong/lua-resty-aws#81) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the code that was previously running on
modulelevel toinitializefunction that are lazily called when needed. This is to avoid theyield accross C-boundaryerrors duringrequire.