chore: harden taskfile common tasks#487
Conversation
Co-authored-by: Codex <noreply@openai.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit a2b3b7c. Configure here.
| Path(os.environ["GOTMPDIR"]).mkdir(parents=True, exist_ok=True) | ||
| subprocess.run(["go", "clean", "-cache", "-testcache"], check=True) | ||
| for path in [Path("agentapi"), Path("coverage.out"), Path(".cache/go-build")]: | ||
| for path in [Path("agentapi"), Path(".cache/go-build"), Path(".cache/go-tmp")]: |
There was a problem hiding this comment.
Clean task no longer removes coverage.out artifact
Low Severity
The clean:go task previously removed coverage.out alongside agentapi and .cache/go-build. When .cache/go-tmp was added, Path("coverage.out") was dropped from the cleanup list instead of being kept. A coverage.out file exists in the repository root, and it is not covered by .gitignore, so task clean will no longer remove this build artifact.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a2b3b7c. Configure here.
| rm -rf .next | ||
| if [ ! -d node_modules ]; then | ||
| bun install --frozen-lockfile | ||
| fi |
There was a problem hiding this comment.
Conditional install skips dependency verification with stale node_modules
Low Severity
The old code always ran bun install --frozen-lockfile, which verified node_modules matched the lockfile on every invocation. The new guard if [ ! -d node_modules ] skips install entirely when the directory exists, even if bun.lock or package.json has changed. This means builds and lints can silently use stale dependencies, which contradicts the hardening intent. Since --frozen-lockfile is already a fast no-op when deps are current, the conditional saves little while weakening correctness.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit a2b3b7c. Configure here.
1 participant
Co-authored-by: Codex noreply@openai.com
Note
Low Risk
Low risk because changes are limited to developer automation scripts, mainly adjusting caches and dependency install behavior. The main risk is CI/local workflow differences due to
npm ci/conditional installs and reduced docs clean targets.Overview
Improves Taskfile reliability by pinning Go temp/cache directories (adds
GOTMPDIR) across build/test/lint/clean and failinglint:goon unformatted files viagofmt -l.Makes chat and docs tasks more deterministic: chat build/lint only runs
bun installwhennode_modulesis missing (and clears.nextbefore building), while docs builds switch tonpm ci --ignore-scriptsand call VitePress directly, with an updated status guard around the vendored docs.Adjusts cleanup to remove the new Go temp cache and narrows docs cleanup to just the VitePress cache. Changes are mirrored in both
Taskfile.ymlandagentapi-plusplus/Taskfile.yml.Reviewed by Cursor Bugbot for commit a2b3b7c. Bugbot is set up for automated code reviews on this repo. Configure here.