Skip to content

Fixes #157: Incorrect Fahrenheit temperature rounding#158

Open
ronaldheft wants to merge 1 commit intoKraigM:masterfrom
ronaldheft:master
Open

Fixes #157: Incorrect Fahrenheit temperature rounding#158
ronaldheft wants to merge 1 commit intoKraigM:masterfrom
ronaldheft:master

Conversation

@ronaldheft
Copy link
Copy Markdown

Siri / HomeKit occasionally displays the incorrect temperature when the Nest's units are set to Fahrenheit.

For example, "Hey Siri set the temperature to 72-degrees" -> "Ok, I set the temperature to 71.6-degrees Fahrenheit."

This issue is a result of the "minStep" property being set to 0.5. Since HomeKit operates exclusively in Celsius, with minStep being set, HomeKit is rounding the Fahrenheit value in to the nearest 0.5 degree Celsius before setting the value, which can results in some weird rounding when converting Celsius back to Fahrenheit.

For the above: 72-degress F = 22.22-degrees C. HomeKit rounds that to 22-degrees C, which is ends up being 71.6-degrees F when converted back.

This minStep restriction is unnecessary for Fahrenheit temperatures since the when setting the temperature, the temperature is already rounded to nearest valid unit the Nest API will accept. Additionally, HomeKit is limited to 1-degree increments for Fahrenheit units.

Fixes #157

Only set minStep for Celcius temperatures

Fix unit typo
@chrisjshull
Copy link
Copy Markdown

Great news! I have taken up maintenance of the homebridge-nest plugin in npm. The source code now lives at https://github.com/chrisjshull/homebridge-nest/. To update to the latest version of homebridge-nest, simply run npm update -g homebridge-nest.

I believe I've merged this patch into that repo. If not, please submit a new PR there.

@ronaldheft
Copy link
Copy Markdown
Author

@chrisjshull Awesome, just updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants