Conversation
* Replaced DataFrame array with TypeTuple * Create Group from DataFrame
* Display a single or multiple groups using string group title and integer position. * Also added getGroups * Added more unittest
* Implemented combine to combine Groups to give a DataFrame * Index.extend now takes argument to insert index at a particular position * Added test to check display function on DataFrame without indexing for row
* Added indexToData to convert a level of row index to data column * Removed trailing wite spaces in display() * Updated all display tests
* Index operation to get an element from integral and string index * Index operation to retrieve an entire row/column as an Axis structure.
* Group supports binary operations both row/column * Added unittests to verify consistency
… DataFrame * Reduced code repetition in group.d * Added shorthand operations for DataFrame * Merge two DataFrames to one based on row index * Added unittests to verify correct behavior
Owner
Author
|
Squashed a couple of weird commits. Hope that helps 😅 |
thewilsonator
approved these changes
Jul 11, 2019
|
Argh didn't mean to approve that. |
Owner
Author
|
Thanks for the thorough review. I'll get on the optimization |
* Binary Operations will require an explicit conversion to assign floating point values to integer * Used mixins for ops * Redefined index operations to avoid collisions * Used ref in loops * Removed redundant code * Refactored helpers * Used ptrdiff_t for getPosition * Updated tests to account for change
* Added a template to check for type DataFrame * Used template to verify if the argument for merge is indeed a DataFrame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of work on
groupByandmerge.cc/ @thewilsonator
Ready for review
Some commits are smaller than others due to the ill health 😅. Let me know if you would like any changes. I'll make them ASAP 🏃♂️