Open
Conversation
Deploying with
|
| Latest commit: |
cd35063
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c175ca78.interface-ctb.pages.dev |
| Branch Preview URL: | https://polygon-warning-modal.interface-ctb.pages.dev |
JohnnyGoodpick
force-pushed
the
polygon-warning-modal
branch
from
8883dec to
78d6636
Compare
fensa08
requested changes
Jan 9, 2023
| spender: string | ||
| tokenList: any | ||
| }) { | ||
| // const allTokens = useAllTokens() |
| const contractList = getContractList(tokenList, library, chainId!) | ||
| if (!contractList || contractList?.length == 0) { | ||
| console.log('unable to get contract list') | ||
| // setIsLoadingDone(true) |
| {isLoadingDone && maliciousAllowanceCount == 0 ? ( | ||
| <p style={{ color: 'green' }}> | ||
| {' '} | ||
| You don't have any bad allowances on this account related to Kromatika ! 🎉🎉 |
There was a problem hiding this comment.
paraphrase the text to something more objective and less scary
| console.log(tokenList) | ||
| const filtered = tokenList.filter((v) => { | ||
| //@ts-ignore | ||
| // console.log(v._checksummedAddress) |
| //@ts-ignore | ||
| // console.log(v._checksummedAddress) | ||
| //@ts-ignore | ||
| // console.log(v.tokenInfo.name) |
| }) | ||
|
|
||
| const contractList = createERC20TokenContracts(filtered_addresses, ERC20ABI, library!) | ||
| // if (contractList.length != Object.keys(filtered).length) { |
| ) : isLoadingDone && isMaliciousAllowancesRemoved ? ( | ||
| <p style={{ color: 'green' }}> Malicious allowances have been removed! 🎉🎉</p> | ||
| ) : ( | ||
| <p style={{ color: 'red' }}> An error has occured ! 🎉🎉</p> |
There was a problem hiding this comment.
maybe this case should be empty or atleast it shouldn't display an error has occured; while the txn is not approved and mined on the blockchain (while the process is ongoing), it is displaying "an error has occured"
| if (Object.keys(malicious_allowances).length == 0) | ||
| console.log('You have ' + Object.keys(malicious_allowances).length + ' bad allowances') | ||
| // if (Object.keys(malicious_allowances).length == 0) | ||
| // console.log('You have ' + Object.keys(malicious_allowances).length + ' bad allowances') |
| @@ -27,6 +27,7 @@ export default function AllowanceRemover({ | |||
| const [isLoading, setIsLoading] = useState(false) | |||
There was a problem hiding this comment.
remove // const allTokens = useAllTokens()
| @@ -41,21 +42,29 @@ export default function AllowanceRemover({ | |||
| } | |||
|
JohnnyGoodpick
force-pushed
the
polygon-warning-modal
branch
from
d4a0365 to
463c5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a button that removes bad allowances related to the KROM_LIMIT_MANAGER on Polygon, directly on the kromatika limit page.
Seems like it's running well, one thing to check is that the proper tokenList was used when calling the button component