Make tags param available to plugin

[darrell-k]

No description provided.

[michaelherger]

What is this change supposed to do exactly?

[darrell-k]

It passes through the tags parameter from the UI SlimBrowse command (if present) to the handler. Sorry, I could have been more descriptive above.

[michaelherger]

Oh, is this needed because the handler wouldn't get a reference to the request object?

[darrell-k]

Correct. From XMLBrowser:

$subFeed->{url}->( $client, $callback, \%args, @{$pt});

(confusingly mapped to $client, $cb, $params, $args in the Qobuz plugin.)

So I've added tags to %args in XMLBrowser, as that's where the other SlimBrowse command parameters are passed.

[michaelherger]

Hmm... I'm wondering why none of the other params would be added the same way. Are they included automatically? Are they not forwarded to the handler?

I'm sorry if I'm missing the obvious. I'm away from a "real" computer, haven't set up my tablet for good reviews.

[darrell-k]

They are added explicitly in the existing code, immediately below where I added tags:

slimserver/Slim/Control/XMLBrowser.pm

Lines 516 to 539 in 7321391

	my %args = (params => $feed->{'query'}, isControl => 1);
	if (defined $search && $subFeed->{type} && ($subFeed->{type} eq 'search' || defined $subFeed->{'searchParam'})) {
	$args{'search'} = $search;
	}
	# If we are getting an intermediate level, then we just need the one item
	# If we are getting the last level then we need all items if we are doing playall of some kind
	if (defined $index && $quantity && $depth == $levels && !$isPlaylistCmd) {
	if ($feedMode) {
	$args{'index'} = $index;
	$args{'quantity'} = $quantity;
	} else {
	# hack to allow for some CM entries
	my $j = 10;
	$j = $index if ($j > $index);
	$args{'index'} = $index - $j;
	$args{'quantity'} = $quantity + $j;
	}
	} elsif ($depth < $levels) {
	$args{'index'} = $index[$depth];
	$args{'quantity'} = 1;
	}

[michaelherger]

That code has always been... challenging. There's $args->{something}, and there's $args{somethings}. Not the same... one is a hash ref, the other a hash, and the ref is not pointing at the hash of the almost identical name. Argh... 🤦🏻 Thanks!