Merged
Conversation
peter-newman-loke
requested review from
a team and
THEjacob1000
and removed request for
a team
THEjacob1000
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows use in older codebases
Specifically to allow cache-kit to be used in ordering without needing to upgrade db-kit which requires upgrading major version of knex.
The change to allow it in cache-kit is a single word change, versus a possibly breaking change in ordering.
The only relevant difference in prom-client@14 (vs 12) is that the template parameter defaults to
stringif not specified in 14. So to be compatible, we specify it as was it defaults to in 14.