Guided tour of a calexp object - #57
Conversation
|
Thanks @stargaser, this is very useful! Something that I found confusing about This will provide |
|
Hi @stargaser ! Is this now ready for review? Great if we can merge it today, if possible. Feel free to request code reviews from anyone from the @LSSTScienceCollaborations/dm-stack-club - likewise others, feel free to volunteer to work through David's notebook! |
|
I need to address comments from @kadrlica and I think I need to rebase |
c18596a to
ddb0063
Compare
4793855 to
2e0980b
Compare
|
Ready for review now @drphilmarshall |
drphilmarshall
left a comment
There was a problem hiding this comment.
Thanks @stargaser ! I verified your calexp tour on v16.0, and put a note on what I needed to change. I also standardized the header. Good stuff, thank you!
| "bbox = afwGeom.Box2I()\n", | ||
| "bbox.include(afwGeom.Point2I(2200,3200))\n", | ||
| "bbox.include(afwGeom.Point2I(2800,3800))\n", | ||
| "cutout = calexp.Factory(calexp, bbox, afwImage.LOCAL)" |
There was a problem hiding this comment.
Much preferred these days:
cutout = calexp[bbox, afwImage.LOCAL]
You can drop the LOCAL because you're not dealing with a subimage, making this even more cleaner:
cutout = calexp[bbox]
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "cutout_calexp = butler.get('calexp_sub', bbox=bbox, immediate=True, dataId=dataId)\n", |
There was a problem hiding this comment.
Don't need immediate=True.
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "The result of the `set` command above shows that a calexp and a coadd have the same methods." |
There was a problem hiding this comment.
That's because they're the same class, lsst.afw.image.Exposure.
There was a problem hiding this comment.
Oh, I see now, that makes this result expected!
Coadds have the same methods, but it seems to me that they have different contents...e.g. XY0 is non-zero; many more cosmic rays in the masks; overall masks look much different; PSFs must be an average from the coaddition process? And certainly the dataIds are a lot different. Maybe this part of the notebook needs to focus on those aspects.
Ready for review.
Addresses #52